junrushao commented on code in PR #35: URL: https://github.com/apache/tvm-ffi/pull/35#discussion_r2370025864
########## python/tvm_ffi/testing.py: ########## @@ -16,23 +16,35 @@ # under the License. """Testing utilities.""" -from typing import Any, ClassVar +from __future__ import annotations + +from typing import TYPE_CHECKING, Any, ClassVar from . import _ffi_api from .core import Object from .dataclasses import c_class, field from .registry import register_object +if TYPE_CHECKING: + from tvm_ffi import Array, Map Review Comment: the original intention is to avoid potential cyclic dependencies, but indeed there's no cyclic dependency in this case. will remove ########## python/tvm_ffi/_ffi_api.py: ########## @@ -16,6 +16,37 @@ # under the License. """FFI API.""" +from __future__ import annotations + +from typing import TYPE_CHECKING, Any + from . import registry +if TYPE_CHECKING: Review Comment: will move to a pyi file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
