junrushao commented on PR #35: URL: https://github.com/apache/tvm-ffi/pull/35#issuecomment-3316702976
Looks like the only controversy [1][2] is whether or not we want generated methods to be put under `TYPE_CHECKING` or not. I don't really have strong opinion so @tqchen you may make the call. Arguments on both sides are valid: - Reason why they should reside under `TYPE_CHECKING`: Those are not real methods with concrete implementation. - Reason why they should not reside under `TYPE_CHECKING`: the extra indent looks not super necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
