gemini-code-assist[bot] commented on code in PR #49:
URL: https://github.com/apache/tvm-ffi/pull/49#discussion_r2373203280
##########
python/tvm_ffi/cython/base.pxi:
##########
@@ -191,7 +191,7 @@ cdef extern from "tvm/ffi/c_api.h":
int32_t type_index
int32_t type_depth
TVMFFIByteArray type_key
- const int32_t* type_acenstors
+ const TVMFFITypeInfo** type_ancestors
Review Comment:
This change correctly defines `type_ancestors` as `const TVMFFITypeInfo**`,
which aligns with the C-level `TVMFFITypeInfo` struct definition in
`include/tvm/ffi/c_api.h`. The previous definition `const int32_t*
type_acenstors` was incorrect. This fix is crucial for the correctness of type
hierarchy traversal, which is a core part of the new auto-creation feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
