On 19 June 2018 at 19:13, Philippe <[email protected]> wrote: >> For the above reasons I'd lean towards not running it globally and just >> using it >> on new changes. > > +1, based on my clang-format experience on a big application. > > BTW, keep in mind that you can disable clang-format on code sections with: > > // clang-format off > // clang-format on
When I last experienced a large-scale clang-format reformat, it really hurt development during the churn. We should somehow manage to do it during a time when there aren't many pending patches in the pipeline. I'm not concerned about git-blame; that has never been a problem after reformats. However, I do not care about indentation nor do I want to spend time on it either way, it has no actual effect on readability and maintainability of code, and consistency outside the file you're in has never mattered to me one bit. IOW, I'm not opposed to reformats and auto-checking of clang-format (or even hooking it), but I do not see it as a thing with all that great return-of-investment. _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
