Relying upon qt5 submodule pins is the problem. The underlying issue is
atomicity of commits. Oswald is right.
We need to have a way to provide atomic commits across modules at least
the CI should see these as atomic and integrate accordingly.
On 12/08/2017 09:20 AM, Konstantin Tokarev wrote:
08.12.2017, 17:14, "Tor Arne Vestbø" <[email protected]>:
On 08/12/2017 14:54, Sergio Ahumada wrote:
an old concept that used to pin the sha1 of repo/module's dependency, eg
http://code.qt.io/cgit/qt/qtdeclarative.git/commit/sync.profile?id=ab6b6b7c7ab544d347d59b7eefad403837d94012
that was replaced in, eg,
http://code.qt.io/cgit/qt/qtdeclarative.git/commit/sync.profile?id=9bfe3324f7fa94e1f272c35bcb943daa2669edba
for
http://code.qt.io/cgit/qt/qt5.git/tree/.gitmodules
Ouch, what was the rationale for making this change?
IIRC, it was done to have all things in one place. Integration is strongly
affected by used qt5 commit, which determines provisioning configuration and
platform configs, so it's logical to use its submodule references as well.
tor arne
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
