On 08.12.2017 14:23, Edward Welbourne wrote:
On 07/12/2017 17:22, Liang Qi wrote:
The changes that are important to be merged up before other changes
should have a special tag, such as API_CHANGE in the commit
message. Then the script used to do the merges could stop and/or warn
about commits with this tag in the message, which would make the
merge easier. We can also apply this check into the submodule update
script.
Tor Arne Vestbø (8 December 2017 13:41)
Can't the script detect this by looking for changes to public headers?
That's possible (albeit possibly trickier than you think), but not all
changes to public headers present a problem that this needs to attend
to. Our API reviews do require actual reviewers, after all.
Eddy, who has no idea what sync.profile pinning is.
an old concept that used to pin the sha1 of repo/module's dependency, eg
http://code.qt.io/cgit/qt/qtdeclarative.git/commit/sync.profile?id=ab6b6b7c7ab544d347d59b7eefad403837d94012
that was replaced in, eg,
http://code.qt.io/cgit/qt/qtdeclarative.git/commit/sync.profile?id=9bfe3324f7fa94e1f272c35bcb943daa2669edba
for
http://code.qt.io/cgit/qt/qt5.git/tree/.gitmodules
--
Sergio Ahumada
[email protected]
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
