Hello

One of the duties of a maintainer is to ensure that every contribution to the
code he/she maintains is being reviewed. That is, if no one else approves or
rejects, the maintainer has the duty to make that happen. I've done this in
the past and approved based on +1 given by other people, or by reviewing stuff
myself.

What are we supposed to do when no one else approves or rejects a commit that
we created ourselves? Or worse, when no one reviews at all?

My question applies mostly to QtDBus, since I don't expect most people will
know anything about that module. I've (ab)used Stephen's goodwill to review
simple things, but I don't expect him to understand the message delivery path
for example.

What is the suggested procedure?

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Software Architect - Intel Open Source Technology Center
     Intel Sweden AB - Registration Number: 556189-6027
     Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Reply via email to