A few thoughts here. 1. Will sysevents in the core create challenges for portability to other OS? (Matt? Andriy? Brian?)
2. Can we please use ILLUMOS_KERN_PUB instead of SUNW_KERN_PUB for these events? (spa_history.c line 212) Otherwise it seems reasonable to me. On Thu, Apr 28, 2016 at 8:06 AM, Dave Eddy <[email protected]> wrote: > Originally created: https://smartos.org/bugview/OS-4489 > webrev: > https://us-east.manta.joyent.com/bahamas10/public/webrev/OS-4489/index.html > > See illumos bug page for example output from this change. > > Originally reviewed in illumos-joyent by > Reviewed by: Patrick Mooney [email protected] @pfmooney > <https://github.com/pfmooney> > Reviewed by: Joshua M. Clulow [email protected] @jclulow > <https://github.com/jclulow> > Reviewed by: Josh Wilsdon [email protected] @joshwilsdon > <https://github.com/joshwilsdon> > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/openzfs/openzfs/pull/101 > Commit Summary > > - 6939 add sysevents to zfs core for commands > > File Changes > > - *M* usr/src/uts/common/fs/zfs/spa_history.c > <https://github.com/openzfs/openzfs/pull/101/files#diff-0> (48) > - *M* usr/src/uts/common/os/log_sysevent.c > <https://github.com/openzfs/openzfs/pull/101/files#diff-1> (5) > - *M* usr/src/uts/common/sys/fs/zfs.h > <https://github.com/openzfs/openzfs/pull/101/files#diff-2> (9) > - *M* usr/src/uts/common/sys/sysevent.h > <https://github.com/openzfs/openzfs/pull/101/files#diff-3> (3) > - *M* usr/src/uts/common/sys/sysevent/eventdefs.h > <https://github.com/openzfs/openzfs/pull/101/files#diff-4> (2) > > Patch Links: > > - https://github.com/openzfs/openzfs/pull/101.patch > - https://github.com/openzfs/openzfs/pull/101.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly or view it on GitHub > <https://github.com/openzfs/openzfs/pull/101> > *openzfs-developer* | Archives > <https://www.listbox.com/member/archive/274414/=now> > <https://www.listbox.com/member/archive/rss/274414/28015165-f50abbe5> | > Modify > <https://www.listbox.com/member/?&;> > Your Subscription <http://www.listbox.com> > > ------------------------------------------- openzfs-developer Archives: https://www.listbox.com/member/archive/274414/=now RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa Modify Your Subscription: https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c Powered by Listbox: http://www.listbox.com
