On Mon, 30 Nov 2015 03:02:07 +0300, Yuri Pankov wrote:
On Sun, 29 Nov 2015 17:42:17 -0500, Dan McDonald wrote:
I've updated the webrev below with a missing pkg manifest change, and am
running zfstest as I type this. It won't be done until later, and I want to
run it again with an actual 4986 fix, but this is what I'd like to upstream
either by itself, or as part of the fix for 4986.
I think this test case belongs in cli_root/zfs_receive, not refquota
itself, as we fail to receive intermediate snapshot due to refquota
setting (if I understand it correctly).
Nitpicking:
- assertion text (and DESCRIPTION) do NOT describe the problem
- non-descriptive filename
- excessive indents
- excessive comments - you already have them in STRATEGY
You need to add it to runfiles as well.
Sent from my iPhone (typos, autocorrect, and all)
On Nov 25, 2015, at 9:23 AM, Dan McDonald <[email protected]> wrote:
Figured this should be delivered alongside or before a fix for 4986:
http://kebe.com/~danmcd/webrevs/test-4986/
This is a preliminary review --> I've not yet tested this myself, mostly
because I'm trying to fix 4986 itself at the moment. I wanted it out there, so I
didn't forget and neither will the community.
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
