I personally feel that labelclear should follow the same syntax as other
'zpool' command. This means we shouldn't introduce /dev/dsk unless we're
prepared to just change the syntax of 'zpool add', 'zpool create', etc.
Comparing this to 'zdb' is not a valid argument since most users probably have
never heard or used 'zdb'. Why can't this just look at the 'whole_disk'
property to determine how it should treat this device? If a 'whole_disk' is
provided but the original pool was not created this way, then it should just
fail (just like othe 'zpool' commands would). If a specific platform is not
using 'whole_disk' the way it was intended then at least this command would
behave in a consistent (although potentially broken) manner.
It seems like there is a bigger discussion (outside of this request) about the
way we should standardize on the device naming for ZFS. The way that ZFS auto
labels disks might be a bad idea across platforms. The intent was to simplify
the administration, which is has accomplished for illumos, but I'm not sure
others feel that it has successfully accomplished that in linux, freebsd, or OS
X. If we've failed to simplify it on other platforms then we should discuss
that outside of this pull request. Keeping things consistent for now would
reduce confusion.
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/32#issuecomment-152831039
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
