On 16/11/2020 14:40, Kinsey Moore wrote:
-----Original Message-----
From: Sebastian Huber<sebastian.hu...@embedded-brains.de>
Sent: Monday, November 16, 2020 07:35
To: Kinsey Moore<kinsey.mo...@oarcorp.com>;devel@rtems.org
Subject: Re: [PATCH 2/2] spec/aarch64: Only apply SUBALIGN(4) to ILP32
On 16/11/2020 14:15, Kinsey Moore wrote:
The SUBALIGN(4) required on rtemsroset and rtemsrwset for ILP32 builds
was previously present on LP64 builds and causes no issues within
RTEMS, but causes relocation/alignment issues when building libbsd.
This restricts those alignment changes to ILP32 builds.
Please check it in if you think it is necessary.
What troubles me a bit is that these SUBALIGN() stuff is present at all.
It also troubles me that the splinkersets01 test case didn't catch this problem.
That test was what originally caught the problem during development of the A53
BSP. This patch isn't the addition of a fix for the alignment problems, it's an
adjustment of the original fix to be compatible with libbsd's use of
rtemsroset/rtemsrwset linker sections.
So, this SUBALIGN() is just a workaround for some other problem? It
would be good to document this known issue somewhere, for example a
ticket. Is this an upstream problem in GCC or the GNU linker?
--
embedded brains GmbH
Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
Phone: +49-89-18 94 741 - 16
Fax: +49-89-18 94 741 - 08
PGP: Public key available on request.
embedded brains GmbH
Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
