-----Original Message-----
From: Sebastian Huber <sebastian.hu...@embedded-brains.de> 
Sent: Saturday, November 14, 2020 06:23
To: Kinsey Moore <kinsey.mo...@oarcorp.com>; devel@rtems.org
Subject: Re: [PATCH 1/2] spec/aarch64: Ensure that libbsd can build properly

>On 13/11/2020 16:04, Kinsey Moore wrote:
>
>> -----Original Message-----
>> From: Sebastian Huber<sebastian.hu...@embedded-brains.de>
>> Sent: Friday, November 13, 2020 04:23
>> To: Kinsey Moore<kinsey.mo...@oarcorp.com>;devel@rtems.org
>> Subject: Re: [PATCH 1/2] spec/aarch64: Ensure that libbsd can build 
>> properly
>>
>> On 12/11/2020 14:32, Kinsey Moore wrote:
>>>>    install:
>>>> +- destination: ${BSP_INCLUDEDIR}/bsp
>>>> +  source:
>>>> +  - bsps/arm/include/bsp/linker-symbols.h
>>>> +  - bsps/arm/include/bsp/start.h
>>>>    - destination: ${BSP_INCLUDEDIR}/dev/clock
>>>>      source:
>>>>      - bsps/include/dev/clock/arm-generic-timer.h
>>> This is a bit strange. You install files which are not used to build the 
>>> BSP?
>> They are used by bspstart.c and bspstarthooks.c so they're used to build the 
>> BSP, but they're only required for some external applications and libraries 
>> which is why they weren't already being installed. This matches how ARM, 
>> RISC-V, and other BSPs install start.h and linker-symbols.h.
> How did you add "bsps/arm/include" to the include path used for the
> aarch64 BSPs?

Ah, sorry. I was missing the point you were trying to make. Those files are 
similar enough that it would allow compilation, but you're right. Those are the 
wrong file paths. I'll update the patch.

Kinsey
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to