On Sat, Apr 4, 2020 at 4:28 PM Gedare Bloom <ged...@rtems.org> wrote:
>
> On Sat, Apr 4, 2020 at 4:25 PM Vijay Kumar Banerjee
> <vijaykumar9...@gmail.com> wrote:
> >
> >
> >
> > On Sun, Apr 5, 2020, 3:45 AM Gedare Bloom <ged...@rtems.org> wrote:
> >>
> >> Use in tester to allow defining custom rtems_version
> >> to use in tools.
> >>
> >> Closes #3671.
> >
> >
> > Looks like someone else was also chasing this bug with a similar approach ;)
> > https://lists.rtems.org/pipermail/devel/2020-April/059001.html
> >
> Yeah, we could have collaborated on IRC! :)
>
> Am discussing briefly the approaches taken with Chris.
>
After IRC discussion, we think the approach should be a little more
rigorous. An idea to pursue is to provide a way to align the ini/cfg
files to be able to use the triplet in rtems-tool. This would be both
more flexible but also should be more easily checked for correctness.
It will require probably rewriting the 25 or so cfg/ini files that use
the %rtems_version macro, and eliminate the macro.
> >
> >
> >> ---
> >> rtemstoolkit/options.py | 1 +
> >> tester/rtems/version.cfg | 4 +++-
> >> 2 files changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/rtemstoolkit/options.py b/rtemstoolkit/options.py
> >> index 32a7016..e991bc8 100644
> >> --- a/rtemstoolkit/options.py
> >> +++ b/rtemstoolkit/options.py
> >> @@ -80,6 +80,7 @@ class command_line(object):
> >> self.long_opts = {
> >> # key macro handler
> >> param defs init
> >> '--jobs' : ('_jobs', self._lo_jobs,
> >> True, 'default', True),
> >> + '--rtems-version' : ('rtems_version', self._lo_string,
> >> True, None, False),
> >> '--log' : ('_logfile', self._lo_string,
> >> True, None, False),
> >> '--macros' : ('_macros', self._lo_string,
> >> True, None, False),
> >> '--force' : ('_force', self._lo_bool,
> >> False, '0', True),
> >> diff --git a/tester/rtems/version.cfg b/tester/rtems/version.cfg
> >> index 2cd9073..0ca057e 100644
> >> --- a/tester/rtems/version.cfg
> >> +++ b/tester/rtems/version.cfg
> >> @@ -32,4 +32,6 @@
> >> # RTEMS Version
> >> #
> >>
> >> -%define rtems_version 5
> >> +%if ! %{defined rtems_version}
> >> + %define rtems_version 5
> >> +%endif
> >> --
> >> 2.17.1
> >>
> >> _______________________________________________
> >> devel mailing list
> >> devel@rtems.org
> >> http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
