On Mon, Aug 22, 2016 at 11:25 AM, Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote:
> Sorry, for being so pedantic, but it will be probably me who updates the > libbsd with about 800 files to next FreeBSD versions. Please go through > your complete patch series again and fix all places that don't follow the > guidelines and my mail comments. It looks better now, but there are still > some spots left. > I totally understand. I would work on the patches till they become perfect and mergable to the master. Its just that I could not find the mistakes. Maybe I am still getting trained for finding them. You can always point that out to me and I would definately correct them. At the end pushing the clean, understandable and usable code is my goal, too. > If you think the guidelines could be more clear, need an explanation or > examples, then we should address this first. I could use some examples on the last rule " Do not disable option header includes via guards. Instead, add an empty option header, e.g. `rtemsbsd/include/rtems/bsd/local/opt_xyz.h`. In general, provide empty header files and do not guard includes. " > > -- > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail : sebastian.hu...@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. > > -- Deval Shah Graduate Student, B.E. (Hons.) Electrical and Electronics Engineering BITS Pilani Hyderabad Campus <http://www.bits-pilani.ac.in/hyderabad/> Github Profile <https://github.com/deval-maker> ᐧ
_______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
