On Thu, Feb 26, 2015 at 11:47 AM, Sebastian Huber <sebastian.hu...@embedded-brains.de> wrote: > Hello Martin, > > sorry, I should have look at your bsp-start-init-registers.s earlier. This > stuff looks so generic, that it should go directly into start.S. I guess the > TMS570 will not remain the only ARM core with a lockstep feature.
Thanks for the feedback. So that means I should discard the BSP_START_NEEDS_REGISTER_INITIALIZATION symbol altogether and unconditionally call the bsp_start_init_registers routines in arm/shared/start/start.S? I still think the routines themselves should be kept on a separate .S file, though, if only to keep start.S as short and clean as possible. > You don't have to save and restore the r0 in a function since its a volatile > register. > > On 26/02/15 15:38, Martin Galvan wrote: >> >> Changes from v1: >> * Add bsp_start_* prefixes. >> * Add *_banked_fiq suffixes to make it clear it's referring to the >> FIQ mode banked regs. >> >> Follow-up from here: >> >> https://lists.rtems.org/pipermail/devel/2015-February/009974.html >> >> This patch adds the macro BSP_START_NEEDS_REGISTER_INITIALIZATION and >> three hooks for BSP-specific register init code to arm/shared/start.S. Said >> hooks are bsp_start_init_registers_core (intended for initializing the ARM >> core registers), bsp_start_init_registers_banked_fiq (for the FIQ mode >> banked registers) and bsp_start_init_registers_vfp (for the FPU registers). >> BSP_START_NEEDS_REGISTER_INITIALIZATION would be defined in a BSP's >> configure.ac (so that it appears in its bspopts.h). >> >> This patch also adds the register init code required by the TMS570. We've >> tested it with the tms570ls3137_hdk.cfg config and it works fine. > > > -- > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail : sebastian.hu...@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG. > -- Martín Galván Software Engineer Taller Technologies Argentina San Lorenzo 47, 3rd Floor, Office 5 Córdoba, Argentina Phone: 54 351 4217888 / +54 351 4218211 _______________________________________________ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
