> Moreover, because typically (in GH for instance) the PR (title and body) is > auto-generated from the initial commit messages, if you apply the guidelines > to these commits you kill two birds with one stone: you get a nice PR "for > free" and also help the review.
(this isn't really a comment on this RFC since it's more about implementation details) This is a bit of a back and forth with committers / PR authors. As @leandron said it's ultimately the committer's responsibility to ensure that the final commit message (which is presented to them on GitHub when clicking "Squash and Merge") is of high quality. GitHub will auto-fill out that box with the commit messages so an author carefully rebasing their PR commit messages to match their PR title and body can ensure that it is going to be good, but I think that'd be difficult to coordinate across all contributors. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1218337517 You are receiving this because you are subscribed to this thread. Message ID: <apache/tvm-rfcs/pull/88/c1218337...@github.com>
