> > I think we should explicitly say that whoever is merging the PR needs to > > copy the description of the PR into the commit message (unless we have > > changed GitHub to do this automatically?). Having clear instructions (like > > how to copy formatting) for mergers would be really nice. > > @leandron @areusch @mbaret @driazati wdyt?
It is a responsibility of the _author_ to keep the GitHub PR title and description consistent with the work done. That's just basic housekeeping. It is a responsibility of the _committer_, by the time the GitHub PR is ready to be merged, to make sure a message exists and is same, then copy the PR description and set as contents of the commit message the will be done in the git repository. This RFC is not describing _how_ people should do their work. It is merely creating a baseline for what is acceptable to maintaining a healthy repository with tracking of commits that contains a description of the changes being made. > Having clear instructions (like how to copy formatting) for mergers would be > really nice. It is out of scope for this specific RFC text to have such information (as in a _step-by-step_ guide here). These guidelines you suggest are implementation details that we can do in many ways, prior to officially communicating committers about this new rule - when it comes to effect. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1217692311 You are receiving this because you are subscribed to this thread. Message ID: <apache/tvm-rfcs/pull/88/c1217692...@github.com>
