```
They can be used during target creation similar to other sub_target strings
ut_target = tvm.target.Target("ultra_trail -ultra_trail_attr_1=attr1
-ultra_trail_attr_2=attr2")
```
```
This could probably be solved by adding type and/or default arguments to the
argument parser, e.g.:
self._register_target_attr("ultra_trail_attr_1", default=False)
```
This aligns with A2.2 -- directly registering each attribute. I think this is
fine for UMA-v1 and aligns with state of TVM targets today. Should we just put
a note that for future considerations, to include a registration for string
preprocessor (A2.1) to extract attributes ?
```
For A1:
I would like to keep the phases. They definitely need proper documentation, but
I think a handfull of phases (e.g., PRE_PARTITIONING, POST_PARTITIONING, ...)
provide more orientation for new users than having to explicitly define the
dependencies to other passes. We could think of also supporting the before and
after options to provide more flexibility for experienced users.
```
Again, I think phase approach is fine for v1 as we already have that in the
core compiler (which is also int based) but I'd appreciate if we can put a
"name" to ease the reasoning in future. Similarly, we could also note as future
work to define dependencies on passes -- if and when the TVM core compiler
improve its pass infrastructure we could be able to use that information.
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/60#issuecomment-1128579875
You are receiving this because you are subscribed to this thread.
Message ID: <apache/tvm-rfcs/pull/60/c1128579...@github.com>
