Thanks @gromero for starting this RFC! I think sorting out commit messages will have a very good impact down the line in organising the project as a whole.
Adding automation to check/enforce this is a great and I support it very much, but I think the important thing at project level as a result of this RFC is that during review we can point authors of PRs to those guidelines so that we can politely ask for better commit messages. [quote="tkonolige, post:10, topic:12334"] I think some people prefer that new changes to a PR come as new commits so that they can review them on a per-commit basis instead of having to re-review the entire PR. [/quote] I think there is a balance here to accommodate "_ways people like to organise their own work_" with the minimum we - as an open source project - need to guarantee some uniformity and quality to the contributions we merge. This is what this RFC is trying to achieve IMHO. On the topic of "stacking new commits on top of a PR", I feel it is important that such commits are organised in a way that they mean something, so that they can have a commit message that means something more than e.g. "fix lint", "fix test" or "cleanup". These changes should be merged into their relevant commits within a PR. In terms of how to concretely implement the changes, I think we should make this part of the documentation, near the committer/reviewer guidelines, similar to what other projects e.g. [LLVM](https://llvm.org/docs/DeveloperPolicy.html#commit-messages) do. [quote="manupa-arm, post:11, topic:12334"] With that spirit, I would like to suggest something, though I admit I have no experience in using this (hoping someone here might have used this :slight_smile: ) , [Gitlint ](https://jorisroovers.com/gitlint/). I think we can enable this in the CI, fairly easily depending on the collective opinion of the community. [/quote] I think this is a great suggestion @manupa-arm, so that we can codify the bare minimum and save a lot of reviewer's time in pointing out empty/not tagged commit messages. --- [Visit Topic](https://discuss.tvm.apache.org/t/commit-message-guideline/12334/13) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/eb6e95c9676a520783306efbf4bbeb25d04f87ab6cd912399c92fd1075ea46d5).
