Thanks @gromero for taking this initiative.
I would actually push us to take a pragmatic route to enforce these (kind of agreeing @driazati ) given the distributed nature of the TVM/OSS project, failing that we fallback to being at least a "guideline" -- which we dont have at the minute :) . I've been spending sometime thinking about this how to automate this (like in a way a linter would perform) -- In the past, we have seen majority of review cycles are spent fixing commas, spaces, etc -- which got fixed using a linter in the CI. (For more info : https://discuss.tvm.apache.org/t/ci-lint-enabling-clang-format-based-lint-checks/6170) With that spirit, I would like to suggest something, though I admit I have no experience in using this (hoping someone here might have used this :) ) , https://jorisroovers.com/gitlint/. I think we can enable this in the CI, fairly easily depending on the collective opinion of the community. [quote="tkonolige, post:10, topic:12334"] I think some people prefer that new changes to a PR come as new commits so that they can review them on a per-commit basis instead of having to re-review the entire PR. [/quote] I would like to second this. I personally worked on PRs with varying complexities and it is not practical to assume a PR to *always* contain a single commit. However, one thing we might use to solve this would be use "fixup!" or "squash!" commits that the above mentioned tool (Gitlint) can ignore and could be easily removed from the commit message using --autosquash. One thing I dont know is whether/how we can configure Github to use --autosquash. Assuming if we can find out a way to use --autosquash with Github, we might be able to enable linter for commit messages, because the above tool can be made to ignore fixup! or squash! commits. (NOTE : above recommendation of the tool is just based on some short research I did, thus, open for any other alternatives) --- [Visit Topic](https://discuss.tvm.apache.org/t/commit-message-guideline/12334/11) to respond. You are receiving this because you enabled mailing list mode. To unsubscribe from these emails, [click here](https://discuss.tvm.apache.org/email/unsubscribe/7de7f6e893443408faf4db2dbe159d16b0fe6dd32f7c8a1738635994ce0f0162).
