https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
--- Comment #7 from VIN <reachme.va...@gmail.com> --- (In reply to Mark Thomas from comment #5) > (In reply to VIN from comment #3) > > > Please review my patch and let me know in case of any problems. > > Part 1 looks generally OK. You need to use 4 spaces rather than tabs and I > agree with the idea in comment #4 to delog log matches and non-matches. I'm > less sure about a message with the counts. I think it is too noisy for info > and it the summary is debug then why bother since the individual messages > are there. [Pravallika]: I have changed my eclipse settings in such a way that only spaces will be used rather tabs. Not sure why tabs are coming in patch. I also felt that adding count gives too much info to the user. > > Part 2 needs works. Pluggability scans are more than just fragments and the > patch needs to take that into account. [Pravallika]: I assume other than JARs only folders will be scanned(.class files). Is it OK to add them to JARsToSkip property in catalina.properties? If yes, I may need your help to do that. > Also keep in mind the changes are made to trunk first and then back-ported > so if the festure you are implementing isn't in trunk or 8.0.x then patches > are required for those versions too. > > You might find it easier to deal with part 1 first and then part 2. [Pravallika]: Part1 (TLD scanning) is already available in 8.0 and recent trunks. Only 7.0 is not having. Part2 is not part of all 7, 8, 9 trunks. Based on your confirmation, i will give patch for Part1 to Tomcat7. Then i will giev individual patches for Part2 for all 3 versions. Let me know if this is OK. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
