https://bz.apache.org/bugzilla/show_bug.cgi?id=56438
--- Comment #6 from VIN <reachme.va...@gmail.com> --- (In reply to Justin Cranford from comment #4) > The patch sounds great. Three small suggestions to make it just a little > better: > > 1) Can you add a debug message to show positive matches? Logging negative > matches is very useful since Tomcat's configuration uses exclusion filters, > but in hindsight I think showing the positive matches too gives the > developer more visibility into how many jars contain newer servlet 3.0 > pieces. For example, if they notice multiple jars with fragments but > offering similar functionality, they could decide to refactor their > application to eliminate a few of those jars for a little more start up > performance. > [Pravallika]: Do you mean "adding a log message to tell which JAR contains the fragments or TLDs"? If multiple JARs contains them, then too many log messages will be added to the log file which may also slow down the start time. Please think of and let me know so that i can add a INFO message for them. > 2) Is it possible to log a message at the end of scanning to show > positive/negative match totals? I would recommend warning log level if > either negative match total is >0, otherwise info or debug level. A warning > seems appropriate here since unnecessary jar scanning has such a huge > negative impact on startup performance. It would not overwhelm a new user, > it gives them valuable feedback to optimize startup times using your new > debug messages, and it would disappear automatically after they add all the > necessary exclusion filters. > > 3) If you just added 1) and 2) that would be more than enough. However, you > could go a step further and use your code to identify common jar files that > should be filtered. If you added some of them to the default exclusion > filters in catalina.properties then new users would get greater performance > out of default installs. [Pravallika]: In the bug itself there are several JARs mentioned which does not contain any TLds or fragments. Hence i can add them in catalina.properties. Please let me know your opinion. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
