Mark, On 2/24/15 12:59 PM, Mark Thomas wrote: > On 19/02/2015 19:31, Christopher Schultz wrote: >> Mark, >> >> On 2/19/15 1:41 PM, Mark Thomas wrote: >>> On 19/02/2015 17:45, schu...@apache.org wrote: >>>> Author: schultz >>>> Date: Thu Feb 19 17:45:34 2015 >>>> New Revision: 1660953 >>>> >>>> URL: http://svn.apache.org/r1660953 >>>> Log: >>>> Back-port r1660924 to fix >>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=57540 >>>> Expose TLS protocol via a request attribute. >>> >>> Sorry for the delayed feedback. >>> >>> <snip/> >>> >>>> @@ -882,7 +883,7 @@ public class Request >>>> if(attr != null) { >>>> return attr; >>>> } >>>> - if( isSSLAttribute(name) ) { >>>> + if( isSSLAttribute(name) || >>>> name.equals(SSLSupport.PROTOCOL_VERSION_KEY)) { >>> >>> This should be part of the isSSLAttribute() test. I'd it to Globals to >>> for consistency with the other attributes. >> >> I avoided adding it to isSSLAttribute because of this Javadoc for that >> method: >> >> /** >> * Test if a given name is one of the special Servlet-spec SSL >> attributes. >> */ >> >> Since this isn't in the spec, I kept is separate. I think it's a >> reasonable thing to add to the spec: any chance you'd be willing to >> bring it to their attention? > > If you raise the Jira I can comment positively on it. Better for two > people to request it than one.
Created: https://java.net/jira/browse/SERVLET_SPEC-130 Comments and votes appreciated. Thanks, -chris
signature.asc
Description: OpenPGP digital signature
