On 19/02/2015 17:45, schu...@apache.org wrote:
> Author: schultz
> Date: Thu Feb 19 17:45:34 2015
> New Revision: 1660953
>
> URL: http://svn.apache.org/r1660953
> Log:
> Back-port r1660924 to fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57540
> Expose TLS protocol via a request attribute.
Sorry for the delayed feedback.
<snip/>
> @@ -882,7 +883,7 @@ public class Request
> if(attr != null) {
> return attr;
> }
> - if( isSSLAttribute(name) ) {
> + if( isSSLAttribute(name) ||
> name.equals(SSLSupport.PROTOCOL_VERSION_KEY)) {
This should be part of the isSSLAttribute() test. I'd it to Globals to
for consistency with the other attributes.
Hmm. That does mean we end up with multiple definitions. That seems wrong.
I haven't checked how reasonable the following is...
How about for trunk drop the Globals constants and use the ones from
SSLSupport. For the back-port, deprecate the the Globals ones and define
them in terms of SSLSupport.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
