On 01/04/2015 14:30, Violeta Georgieva wrote: > Hi, > > 2015-04-01 14:41 GMT+03:00 Mark Thomas <ma...@apache.org>: >> >> On 01/04/2015 11:45, violet...@apache.org wrote: >>> Author: violetagg >>> Date: Wed Apr 1 10:45:33 2015 >>> New Revision: 1670610 >>> >>> URL: http://svn.apache.org/r1670610 >>> Log: >>> Removed debug messages as they do not give any valuable information and > floods the log files with empty rows. Patch provided by Polina Genova. >> >> Are you sure that statement holds for all possible inputs to the >> digester (server.xml, context.xml, web.xml, TLDs etc.) - both valid and >> mal-formed?. >> >> No objections to removing them if they are always empty but I'm not >> convinced that that is the case. >> > > Checked with Tomcat 8.0.21 startup with > logger org.apache.tomcat.util.digester.Digester.level = FINEST > > Parsed web.xml, context.xml, server.xml, TLDs in > examples, mbeans-descriptors -> only new lines are logged. > > Then I changes one of the web.xml files of the examples to be invalid -> > again only new lines. (Digester.fatalError Parse Fatal Error at line 28 > column 5: The end-tag for element type "description" must end with a '>' > delimiter.) > > Any other checks that can be performed?
None that come to mind. Happy to ditch the code on that basis. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
