On 01/04/2015 11:45, violet...@apache.org wrote: > Author: violetagg > Date: Wed Apr 1 10:45:33 2015 > New Revision: 1670610 > > URL: http://svn.apache.org/r1670610 > Log: > Removed debug messages as they do not give any valuable information and > floods the log files with empty rows. Patch provided by Polina Genova.
Are you sure that statement holds for all possible inputs to the digester (server.xml, context.xml, web.xml, TLDs etc.) - both valid and mal-formed?. No objections to removing them if they are always empty but I'm not convinced that that is the case. Mark > > Modified: > tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java > > Modified: tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1670610&r1=1670609&r2=1670610&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java (original) > +++ tomcat/trunk/java/org/apache/tomcat/util/digester/Digester.java Wed Apr > 1 10:45:33 2015 > @@ -943,9 +943,6 @@ public class Digester extends DefaultHan > > // Recover the body text from the surrounding element > bodyText = bodyTexts.pop(); > - if (debug) { > - log.debug(" Popping body text '" + bodyText.toString() + "'"); > - } > > // Fire "end" events for all relevant rules in reverse order > if (rules != null) { > @@ -1148,9 +1145,6 @@ public class Digester extends DefaultHan > > // Save the body text accumulated for our surrounding element > bodyTexts.push(bodyText); > - if (debug) { > - log.debug(" Pushing body text '" + bodyText.toString() + "'"); > - } > bodyText = new StringBuilder(); > > // the actual element name is either in localName or qName, depending > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
