https://issues.apache.org/bugzilla/show_bug.cgi?id=56418

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
(In reply to Sylvain Laurent from comment #2)
> OK, I renamed the method to "checkAndOutputContextDeploymentStatus", see new
> patch attached.

I'm all for clear method names but that seems a little long

outputDeploymentResult()

should do.

> If this is OK, I can commit it since I should still have commit rights.
> But I did not follow much tomcat dev lately : should I commit on 8.x  then
> 7.x ?

Yes. Commit to 8.0.x and then svn merge back to 7.0.x.

> Should I update the changelog in the same commit or different one ?

Ideally the same one.

> Or if you prefer to commit this yourself, be my guest ;-)

As I am looking at this now I'll do it (but you will get the credit/blame in
the changelog).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to