https://issues.apache.org/bugzilla/show_bug.cgi?id=56418
--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> --- Comment on attachment 31536 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31536 Proposed patch on tomcat7 trunk The first and second chunks of your patch change behavior (by adding an isAvailable check). Is that the real fix for this bug? In general, I'm not a fan of having a "check" method dump anything to the output writer. Would it be possible to re-write the patch with the re-factored method but not dump any output? Or, maybe just change the name so it's clear that stuff will be printed to the output writer (even though it should be obvious to the reader than the writer is bring used since it's passed as a parameter). -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
