2014-03-07 19:17 GMT+04:00 Rémy Maucherat <r...@apache.org>: > 2014-03-04 17:16 GMT+01:00 Rémy Maucherat <r...@apache.org>: > >> The code is there (rebased to the current trunk): >> https://github.com/rmaucher/tomcat >> >> Updated commit here: > https://github.com/rmaucher/tomcat/commit/614d8c43d8d1f3eeb4d5e4c2493ead589a72bf2c > > I have removed the two main hacks and the testsuite status is relatively > clean (some failures though, but some of theses are tests which have a > timing which looks a bit too adapted for the other connectors; I did look > individually at all the problems and made some fixes). > > So far there are 3 people in favor of merging this in the current trunk > (still unbranched 8.0). >
1. It is a month since release 8.0.3 and thus I think 8.0.4 is expected in a week or so.. I am -1 to destabilize 8.0.x now. To this, as you are saying that some tests do not pass. I woudn't want to make buildbot fail this close to a release, as we may miss something important. So I think the time to merge this is not earlier than 8.0.4 is voted and released + some time to cool off. I think that is about 10 days from now. 2. How am I supposed to review this? Is there some viewable "patch" against trunk? The comments below are from a quick review of https://github.com/rmaucher/tomcat/commit/614d8c43d8d1f3eeb4d5e4c2493ead589a72bf2c 1) There are a number of unrelated changes, including some comment / typo fixes. That does not help reviewing. Why aren't those in Tomcat trunk yet? 2). There is a lot of code that from the first glance seems similar to Nio1 one. Just a matter of preference, not a stopper. (In your opening e-mail you say there are many differences. This similarity is my first impression. Maybe there aren't any. I'd need some time to compare). 3). What are the selling points of this implementation? The documentation part of the patch does not say anything in particular. Also my -1 that it does not say that this connector is an "experimental" one. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
