2013/12/13 Rémy Maucherat <r...@apache.org>
>
> 2013/12/13 Violeta Georgieva <miles...@gmail.com>
>
> > I found another issue:
> > If a tag file is placed in a jar file in WEB-INF/lib and then is used,
the
> > The change in the code is introduced with r1541960
> >
> > Besides that the message is wrong because we check only for WEB-INF/tags
> > [1], what should be done in addition?
> >
> > [1]
> >
org.apache.jasper.compiler.TagLibraryInfoImpl.createTagFileInfo(TagFileXml,
> > Jar)
> >
> > 286 } else if (!path.startsWith("/WEB-INF/tags")) {
> > 287 err.jspError("jsp.error.tagfile.illegalPath", path);
> > 288 }
> >
>
> It looks like the condition was not refactored correctly.
Unfortunately with that fix I'm receiving FNF:
java.io.FileNotFoundException: /META-INF/tags/my.tag
org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:235)
org.apache.jasper.compiler.TagFileProcessor.loadTagFile(TagFileProcessor.java:579)
org.apache.jasper.compiler.TagFileProcessor.access$000(TagFileProcessor.java:50)
org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:661)
org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521)
org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2411)
org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2417)
org.apache.jasper.compiler.Node$Root.accept(Node.java:464)
org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
org.apache.jasper.compiler.TagFileProcessor.loadTagFiles(TagFileProcessor.java:679)
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:231)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)
I'll try to create a test case for that.
