2013/12/12 Mark Thomas <ma...@apache.org>
>
> The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
> for voting.
>
> Given this is a release candidate I am working on the basis that it is
> equivalent to an alpha. The main changes since RC5 are:
> - Better handling of generic types in the WebSocket 1.0 implementation
> - Refactor resource handling for the class loader
> - Add Cobertura support to the unit tests
> - Remove anti-Jar locking feature and replace it with open stream
>   tracking
> - Update to Commons Pool 2.0 release
> - Complete refactoring of TLD handling including caching of parsed TLDs
> - More consistent handling of XML validation options
> - Much more detailed visibility of DBCP connections pools in JMX
> - Better organisation of JMX beans in the default JConsole view
> - Numerous bug fixes
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-047/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/
>
> The proposed 8.0.0-RC7 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 8.0.0-RC7 alpha
>


I'm receiving NPE when testing an application with jsp that specifies tld
location with relative path:

java.lang.NullPointerException
        org.apache.jasper.compiler.TldCache.getTaglibXml(TldCache.java:97)
        
org.apache.jasper.compiler.TagLibraryInfoImpl.<init>(TagLibraryInfoImpl.java:150)
        org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:411)
        org.apache.jasper.compiler.Parser.parseDirective(Parser.java:469)
        org.apache.jasper.compiler.Parser.parseElements(Parser.java:1455)
        org.apache.jasper.compiler.Parser.parse(Parser.java:139)
        
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:229)
        
org.apache.jasper.compiler.ParserController.parse(ParserController.java:100)
        org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:200)
        org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
        org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
        org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)
        
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)


Here is a test case that I used:

Index: test/org/apache/jasper/runtime/TestPageContextImpl.java
===================================================================
--- test/org/apache/jasper/runtime/TestPageContextImpl.java     (revision 
1549955)
+++ test/org/apache/jasper/runtime/TestPageContextImpl.java     (working copy)
@@ -50,4 +50,19 @@
         Assert.assertTrue(body.contains("OK"));
         Assert.assertFalse(body.contains("FAIL"));
     }
+
+    @Test
+    public void testRelativeTldLocation() throws Exception {
+        Tomcat tomcat = getTomcatInstance();
+
+        File appDir = new File("test/webapp");
+        tomcat.addWebapp(null, "/test", appDir.getAbsolutePath());
+
+        tomcat.start();
+
+        ByteChunk res = new ByteChunk();
+
+        int rc = getUrl("http://localhost:"; + getPort() +
+                "/test/jsp/test.jsp", res, null);
+    }
 }
Index: test/webapp/jsp
===================================================================
--- test/webapp/jsp     (revision 0)
+++ test/webapp/jsp     (working copy)

Property changes on: test/webapp/jsp
___________________________________________________________________
Added: bugtraq:label
## -0,0 +1 ##
+Bugzilla ID (optional)
\ No newline at end of property
Added: bugtraq:url
## -0,0 +1 ##
+https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%
\ No newline at end of property
Added: bugtraq:message
## -0,0 +1 ##
+Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%
\ No newline at end of property
Added: bugtraq:append
## -0,0 +1 ##
+false
\ No newline at end of property
Index: test/webapp/jsp/test.jsp
===================================================================
--- test/webapp/jsp/test.jsp    (revision 0)
+++ test/webapp/jsp/test.jsp    (working copy)
@@ -0,0 +1,2 @@
+<%@ page contentType="text/plain" %>
+<%@ taglib uri="../WEB-INF/test.tld" prefix="test" %>
\ No newline at end of file
Index: test/webapp/jsp/test.jsp
===================================================================
--- test/webapp/jsp/test.jsp    (revision 0)
+++ test/webapp/jsp/test.jsp    (working copy)

Property changes on: test/webapp/jsp/test.jsp
___________________________________________________________________
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property

Reply via email to