-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 22/11/2013 03:16, Jeremy Boynes wrote: > On Nov 21, 2013, at 4:59 AM, ma...@apache.org wrote: > >> Author: markt Date: Thu Nov 21 12:59:36 2013 New Revision: >> 1544165 >> >> URL: http://svn.apache.org/r1544165 Log: Extend the reach of the >> Context attribute xmlValidation to cover XML parsing by Jasper >> the JSP engine. Fix a TODO and enable validation (if required) >> for implicit TLD files. > > JSP 6.2.4 raises issues around attempting to validate JSP Documents > (.jspx and .tagx) due to the mixin's from the jsp: namespace. This > could perhaps be enabled using a separate option from validation of > the descriptors so users can validate the standard files but not > need to add anything to the DOCTYPE/XSD for the application > content.
I'd forgotten about that. A separate option (XmlValidateJspDoc ?) would work here. > Looks like JasperInitializer now reads to read an attribute not an > init-param. In trunk, I'd been trying to decouple Jasper from > Catalina so having the latter set a jasper-specific attribute > reverts that - in TC7 this is controlled for each JspServlet using > a "validating" init-param (i.e. it does not inherit from the > Context). There are multiple aspects to this. Jasper needs to be usable in other containers so it can't depend on Catalina. Both attributes and init-params allow this. There are some things - like XML validation - that apply to both Catalina and Jasper and users shouldn't have to configure this in multiple places. attributes vs. init-params are really just the mechanism used to pass config from Catalina to Jasper in this case. I think it is easier to do this with attributes than init-params. > I've been thinking of adding a descriptor file for Jasper (e.g. > META-INF/jasper.xml to go alongside context.xml) which would > contain configuration of the JSP engine that is currently split > between context init-params, per-servlet init-params, and system > properties. How about we configure validation there? I'm all for anything that reduces the number of system properties we use. I also like the idea of everything being configured in one place. You might also want to consider: - - a global CATALINA_BASE/conf/jasper.xml as well - - an option to ignore any META-INF/jasper.xml similar to deployXML My main concern is for those settings like xmlValidation where Catalina needs to pass the configuration option to Jasper. There needs to be a way to do this and there are times when this setting needs to override the setting in META-INF/jasper.xml. I still think attributes are the best way to do this. Cheers, Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSjyOuAAoJEBDAHFovYFnnZoMP+wW/0PN5OnjKfNtUAk+cpJtz /F8IxG2KjXFMeDmQmPfyGZCBvzSbTxvLRwjzKkws+xJLKOOzcjgC9wa5Rq4SxzXe JRlP/rJ6Nd3Cyda2V4DyVjhRBR20gGr3x3O0i0oxBRVJu//D5Sz0bO4SsOPApytN Cgix5Xbkh2MiVJh+kI+oeeAzzsxiLlgORVKekj5M8WuKSuNI0FUawpTK5m8Wbr4Q qShUm60ZV05w003G263O7k3FS4uCmLZ29lf8+0nqV5nzb9HnUH8zYFCqmKKqZT+V o0Hf2FOas0AOClW3xGENrYsIa5/3w6eDB0DpPOxScqwdPZhk9x9U4FdsuPbbLTCw ZQG6rQGHX95EO8ETfytY8VvYZ8xQUUxbsns4H9zYnTLl0q9CDmVbhwcBvMTkpG/H /tfr+8zOPJvoMOP8Uui0cyb6rSxIy8Kpoup6u5AaLA5x2kocgU2C4CWj7W/15dBp vLt/dB+X/NTdQHILnbRyWnuUd/J0KyxS9cZ8bsyPFoZTh3XJSu9d2jKmAJ10ccJZ Zb2Yo2fF2OBjxC3q1A2B+yMdpSXgE3K3t4dCvhzzp1D8NT05EWFJPMV+jvU+yb/Y YR/+/izLMd+W2i4mob6RQ0QJJOpe5TZF5kJvRELmuFlIXCWzq5RMXCOl2IAQYLZV seuWB6XbaaQ3dRwkT5qa =wkwu -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
