On 17/10/2013 11:35, Konstantin Kolinko wrote: > 2013/10/17 Violeta Georgieva <miles...@gmail.com>: >> 2013/10/17 Mark Thomas <ma...@apache.org> >>> >>> On 17/10/2013 10:52, Violeta Georgieva wrote: >>>> Hi Mark, >>>> >>>> >>>> 2013/10/17 Mark Thomas <ma...@apache.org> >>>>> >>>>> On 16/10/2013 23:47, Konstantin Preißer wrote: >>>>> >>>>>> Hmm, unfortunately it seems the Websocket implementation using the >>>>>> deprecated proprietary API does not work correctly when using the >>>>>> HTTP APR and NIO connector on Windows... >>>>> >>>>> <snip/> >>>>> >>>>>> With the BIO connector, everything works fine. >>>>>> >>>>>> The new JSR 356 examples work fine with BIO, NIO and APR connectors. >>>>>> >>>>>> I have done some digging and I found that with r1516410, the old >>>>>> Websocket implementation works fine with NIO and APR, but with >>>>>> r1516411, it does not work anymore. >>>>> >>>>> I think the safest thing to do is to revert that change. I think I see >>>>> see a better solution but I don't want to risk yet more regressions. >>>> >>>> >>>> I see this as a cancellation of this vote but I would like to hear your >>>> opinion also. >>> >>> As much as it pains me to say it, I think we need a new tag :( >>> >> >> Ok >> I can see you already committed the revert. >> Can I start right now? >> > > o.a.catalina.core.AprLifecycleListener says > protected static final int TCN_RECOMMENDED_PV = 28;
29 needs to be required. I'll fix that now. > Should that be changed to be "29" to match the recently released native > 1.1.29? > > For Tomcat 8 I would even change TCN_REQUIRED_PATCH to be 29, as it > relies on the poller fix that went in 1.1.29. 8.0.x has already had that change made. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
