On 17/09/2013 14:06, Brian Burch wrote: > 2013/9/3 <ma...@apache.org>: >> Author: markt >> Date: Tue Sep 3 19:26:17 2013 >> New Revision: 1519804 >> >> URL: http://svn.apache.org/r1519804 >> Log: >> Tomcat only uses package-info.java files for Javadoc so don't bother > creating empty class > files from them. >> >> Modified: >> tomcat/trunk/build.xml >> > > 1. Docs [1] say that those files are created so that Ant will stop > recompiling them. > > Beware that you re-compilation time may increase.
I was trying to reduce the warnings or text that looked like warnings during the build. I'm not sure whether this change was worth it. > 2. The createMissingPackageInfoClass option is @since Ant 1.8.3. > > BUILDING.txt for trunk says that we require Ant 1.8.x. > I think it is the time to update that. > My opinion is that we may say that we require 1.9.2 (the current > version of Ant). > > [1] http://ant.apache.org/manual/Tasks/javac.html I'm leaning more towards reverting this change. I'm also considering reverting this change: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?r1=1510674&r2=1511907&diff_format=h If there are no objections by the time I get the unit tests passing on all three test platforms, I'll make those changes before I tag 8.0.0-RC2 and back-port as appropriate. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
