2013/9/3  <ma...@apache.org>:
> Author: markt
> Date: Tue Sep  3 19:26:17 2013
> New Revision: 1519804
>
> URL: http://svn.apache.org/r1519804
> Log:
> Tomcat only uses package-info.java files for Javadoc so don't bother creating empty class
files from them.
>
> Modified:
>     tomcat/trunk/build.xml
>

1. Docs [1] say that those files are created so that Ant will stop
recompiling them.

Beware that you re-compilation time may increase.

2. The createMissingPackageInfoClass option is @since Ant 1.8.3.

BUILDING.txt for trunk says that we require Ant 1.8.x.
I think it is the time to update that.
My opinion is that we may say that we require 1.9.2 (the current
version of Ant).

[1] http://ant.apache.org/manual/Tasks/javac.html

Best regards,
Konstantin Kolinko


Sorry to say that I overlooked Konstantin's comments when this post was published. I've just been bitten when I tried building the trunk on a different machine to my usual system.

.. both systems have:
Apache Ant(TM) version 1.8.2 compiled on May 18 2012

.. this system builds perfectly:
java-6-openjdk-i386 javac 1.6.0_27

.. and this one fails:
java-7-openjdk-i386 javac 1.7.0_25

sandboxApache/tomcat8/trunk/build.xml:615: javac doesn't support the "createMissingPackageInfoClass" attribute


https://issues.apache.org/bugzilla/show_bug.cgi?id=52096

says the bug was fixed in ant 1.8.3, but I haven't upgraded to see whether it resolves this particular build failure.

An update to BUILDING.txt would be trivial - hardly worth a new bug report. BUT what (as Konstantin said above) should be put instead of "1.8.x"?

Regards,

Brian

> Modified: tomcat/trunk/build.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1519804&r1=1519803&r2=1519804&view=diff > ==============================================================================
> --- tomcat/trunk/build.xml (original)
> +++ tomcat/trunk/build.xml Tue Sep  3 19:26:17 2013
> @@ -611,7 +611,8 @@
>             optimize="${compile.optimize}"
>             excludes="**/.svn/**"
>             encoding="ISO-8859-1"
> -           includeAntRuntime="true" >
> +           includeAntRuntime="true"
> +           createMissingPackageInfoClass="false" >
>        <compilerarg value="-Xlint:unchecked"/>
>        <classpath refid="compile.classpath" />
>          <exclude name="org/apache/naming/factory/webservices/**" />
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to