On 20/08/2013 06:35, Rainer Jung wrote: > On 19.08.2013 15:22, Mark Thomas wrote:
>> I plan to commit what I have so far once I am happy that the unit tests >> still work. >> >> I do want to look at removing the Java 7 dependency from the WebSocket >> implementation - at least for Tomcat 7 - but I don't have the time to do >> that immediately. Whether to implement this for Tomcat 7, Tomcat 7 & 8 >> or not at all will depend how complex the code ends up being. At the >> moment I simply don't have a feel for it. > > Personal feeling: whoever starts to use the JSR-356 impl now on TC 7 > typically starts something new and should have no problem at all to > directly base his project on Java 7. So if the build script dance works > for the mixed Java version requirements I doubt that we gain a lot by > removing the Java 7 specifics from the websocket code. That is a fair point. It really comes down to how much effort is to remove the Java 7 code. It were (if only!) say 10 lines I'd do it any way. I think things are ready to commit but I still see some unit test failures and I am working through them as it isn't clear if they are genuine failures or a result of the back-port. The intermittent nature of some of the3 unit test failures isn't helping. At least this exercise is forcing me to take a closer look at them. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
