On 19.08.2013 15:22, Mark Thomas wrote: > On 16/08/2013 15:46, Mark Thomas wrote:
> Updating the build script has proved "interesting". The WebSocket > implementation depends on Tomcat internals but was also required to > build the examples. That meant that the WebSocket build script was > significantly intertwined with the main build script. There was also > going to be a lot of duplication between the scripts. > > Therefore, I have opted to move the WebSocket code into the main code > from modules and the build code into the main build script. Considering > the problem we are trying to solve (DBCP must be built with Java 6, > WebSocket must be built with Java 7) the changes required to handle this > are pretty minor. Most of the build script changes are copied straight > from Tomcat 8 and would be required regardless of the Java version used > to build WebSocket. > > I plan to commit what I have so far once I am happy that the unit tests > still work. > > I do want to look at removing the Java 7 dependency from the WebSocket > implementation - at least for Tomcat 7 - but I don't have the time to do > that immediately. Whether to implement this for Tomcat 7, Tomcat 7 & 8 > or not at all will depend how complex the code ends up being. At the > moment I simply don't have a feel for it. Personal feeling: whoever starts to use the JSR-356 impl now on TC 7 typically starts something new and should have no problem at all to directly base his project on Java 7. So if the build script dance works for the mixed Java version requirements I doubt that we gain a lot by removing the Java 7 specifics from the websocket code. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
