On 14 August 2013 20:41, Mark Thomas <ma...@apache.org> wrote: > Summarising the response to this thread so far: > > There is a preference for not strictly enforcing whatever limit is > selected. Rules need exceptions and committers can exercise judgement. > It does create a grey area but the majority is OK with that. > > There is a mix of views on line length but there appears to be support > for increasing the max line length for code and marginally less support > for increasing the max line length for comments. > > Therefore, I'd like to propose the following: > > 1. Introduce a checkstyle enforced hard limit of 200 characters per line > and fix any lines that exceed it. There are currently 24 lines that > exceed this limit. > > 2. Increase acceptable line length for new / modified code and comments > to 100. No mass reformatting would take place. > > 3. Consider further reducing the hard limit to 100 + suitable margin > over time, possibly in stages. For example, reducing it to 120 > identifies 737 lines (quite a few files have multiple long lines so the > number of files affected it a lot less than 737). > > Thoughts? sounds good. > > I'm inclined to fix the lines identified by 1 regardless. 200+ > characters per line is far too wide. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
-- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
