https://issues.apache.org/bugzilla/show_bug.cgi?id=55046
Mohit Soni <mohitsoni1...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #30363|0 |1
is obsolete| |
--- Comment #4 from Mohit Soni <mohitsoni1...@gmail.com> ---
Created attachment 30384
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30384&action=edit
Revised patch to address several comments.
Thanks Mark, it's great to know that a back-port for 7.0.x is being considered.
I have provided a new patch with:
+ ALv2 license headers
+ Removed trailing whitespace (ran ant -Dexecute.validate=true validate, to
verify)
+ Updated test code to use Generics.
+ Removed Generics warnings
+ Renamed mock object to follow TesterXxx pattern.
+ Added missing @Override for interface implementations.
+ Fixed Autoboxing warnings
+ Fixed Javadoc warnings
Still pending:
- No i18n (use of StringManager)
Saw couple of examples from other tomcat classes. Should CORSFilter extends
from FilterBase to use the StringManager ?
- There is already a mock HttpServletRequest that could have been re-used.
Not sure, which one you are referring to. Found couple of implementations.
But, agree that a duplicate shouldn't be there. Can you recommend one that can
be used ?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
