https://issues.apache.org/bugzilla/show_bug.cgi?id=55046
--- Comment #3 from Mark Thomas <ma...@apache.org> --- I've started to merge the patch into Tomcat trunk (with the assumption it will be back-ported to 7.0.x). So far I have the following comments: - ALv2 license headers are missing - No i18n (use of StringManager) - Trailing whitespace - No use of <> (Tomcat 8 is Java 7 minimum) - Javadoc warnings - Generics warnings - Autoboxing warnings - In Tomcat unit tests mock objects are named TesterXxx - There is already a mock HttpServletRequest that could have been re-used - Missing @Override The issues are all minor but this is a large patch so there are a fair few of them. In addition to expecting a clean build (with Checkstyle enabled) we also provide IDE settings for Eclipse that can help with aligning patches with the coding standards (such as there are) for Tomcat. I'll continue working on this tomorrow. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
