On 25/03/2013 15:19, Konstantin Kolinko wrote: > 2013/3/25 <ma...@apache.org>: >> Author: markt >> Date: Mon Mar 25 15:10:12 2013 >> New Revision: 1460708 >> >> URL: http://svn.apache.org/r1460708 >> Log: >> Fix. Thanks to kkolinko >> >> Modified: >> tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java >> >> Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java >> URL: >> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java?rev=1460708&r1=1460707&r2=1460708&view=diff >> ============================================================================== >> --- tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java >> (original) >> +++ tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java Mon Mar >> 25 15:10:12 2013 >> @@ -61,7 +61,7 @@ public class WsSci implements ServletCon >> wsPackage = wsPackage.substring(0, wsPackage.lastIndexOf('.') + >> 1); >> for (Class<?> clazz : clazzes) { >> int modifiers = clazz.getModifiers(); >> - if (!Modifier.isPublic(clazz.getModifiers()) || >> + if (!Modifier.isPublic(modifiers) || >> Modifier.isAbstract(modifiers)) { >> // Non-public or abstract - skip it. >> continue; > > I wonder whether interfaces have "abstract" flag set on their methods > or we need to check for isInterface() here.
I'd expect an interface to be abstract. A quick test confirms this. There is a further requirement for a no-arg constructor that I haven't implemented yet. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
