2013/3/25  <ma...@apache.org>:
> Author: markt
> Date: Mon Mar 25 15:10:12 2013
> New Revision: 1460708
>
> URL: http://svn.apache.org/r1460708
> Log:
> Fix. Thanks to kkolinko
>
> Modified:
>     tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java
>
> Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java?rev=1460708&r1=1460707&r2=1460708&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java (original)
> +++ tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java Mon Mar 
> 25 15:10:12 2013
> @@ -61,7 +61,7 @@ public class WsSci implements ServletCon
>              wsPackage = wsPackage.substring(0, wsPackage.lastIndexOf('.') + 
> 1);
>              for (Class<?> clazz : clazzes) {
>                  int modifiers = clazz.getModifiers();
> -                if (!Modifier.isPublic(clazz.getModifiers()) ||
> +                if (!Modifier.isPublic(modifiers) ||
>                          Modifier.isAbstract(modifiers)) {
>                      // Non-public or abstract - skip it.
>                      continue;

I wonder whether  interfaces have "abstract" flag set on their methods
or we need to check for isInterface() here.

IIRC javap produces different output for interface methods that are
explicitly marked as "public" and ones that do not have such modifier,
though from usage POV they are the same. So I would not wonder if it
is the same here.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to