On 02/11/2013 12:26 PM, Rainer Jung wrote:
On 08.02.2013 14:43, Mladen Turk wrote:
- key not in all KEYS files:
I found it in /tomcat/native/branches/1.1.x/KEYS and on people.a.o,
but it should also be added to
http://archive.apache.org/dist/tomcat/tomcat-connectors/KEYS and
/tomcat/tomcat-connectors/KEYS on the mirrors.
Yeah, I was planning to update those together with this release
since it'll synced at once.
- ant part of build (no regressions, cited from 1.1.24 tests):
- No mentioning of running "ant download" before tests. Without
it test compilation fails.
- "ant run-ssl-server": Could't we include a test certificates in the
test folder? What should the test produce, if run successfully?
- "ant run-local-server": Creates a unix socket "\\.\PIPE\test" in the
examples directory, then waits. How is the test expected to work?
And the file name doesn't seem to be appropriate for Unix.
- run-echo, run-ssl-server and run-local-server: I couldn't figure
out, what those were actually supposed to show (what is a positive
result vs. a negative one).
IMO we should axe all those tests (or have one or two that actually work)
There we made merely for development purposes and since then API and
usage diverged.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
