On 08.02.2013 14:43, Mladen Turk wrote:
> Version 1.1.27 is bug fixing release.
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The VOTE will remain open for at least 48 hours.
>
> The Apache Tomcat Native 1.1.27 is
> [X] Stable, go ahead and release
> [ ] Broken because of ...
+1 to release
Detailed results ("-" indicates things which we could improve). Though
the list is long, it is again shorter than for the previous release.
Overall I'm still +1 for stable, because I didn't find
regressions. But there is room for improvement.
Please note especially the remark about the KEYS file.
+ Tested with APR 1.4.6 and OpenSSL 1.0.1c. Java version 1.7.0_13 for
pure tcnative ests/examples, Tomcat testsuite taken from TC 7 tested
with 1.6.0_39, native part configured against Java 1.5.0_22.
+ Platforms Solaris 8+10 Sparc, SLES 10, 32 and 64 Bits,
SLES 11 64 Bits, RHEL 5+6 64 Bits (no pure tcnative tests on Solaris
8, because no Java 7 available)
+ MD5 OK
+ signatures OK
- key not in all KEYS files:
I found it in /tomcat/native/branches/1.1.x/KEYS and on people.a.o,
but it should also be added to
http://archive.apache.org/dist/tomcat/tomcat-connectors/KEYS and
/tomcat/tomcat-connectors/KEYS on the mirrors.
+ gz and zip for sources consistent
- Except for different permissions: zip seems to also contain group
write permissions. Not a real problem, but it's a bit strange
that perms differ between the archive (no regression).
+ source dist consistent with svn tag
+ config-guess and config.sub up to date. Thanks!
+ recreated release with jnirelease script, results are
consistent with source dist, except for minor expected diffs in
CHANGELOG.txt, build-outputs.mk and generated docs
(whitespace and attribute ordering)
+ make succeeds and builds lib (no warnings)
+ "ant test" succeeds
- all unit tests contained in TC 7 head run successful with
APR connector and this version of tcnative. Execptions are due to
specifics of the systems used for the tests:
- some tribes test on my RHEL 5 system fail. Not a regression,
probably some multicast setup issue.
- TestMaxConnections: failed only on Solaris 8 for bio and nio,
not apr, likely a timing issue on a slow system.
- TestMapper: only performance test fails on slow Solaris 8 system
- ant part of build (no regressions, cited from 1.1.24 tests):
- No mentioning of running "ant download" before tests. Without
it test compilation fails.
- "ant run-ssl-server": Could't we include a test certificates in the
test folder? What should the test produce, if run successfully?
- "ant run-local-server": Creates a unix socket "\\.\PIPE\test" in the
examples directory, then waits. How is the test expected to work?
And the file name doesn't seem to be appropriate for Unix.
- run-echo, run-ssl-server and run-local-server: I couldn't figure
out, what those were actually supposed to show (what is a positive
result vs. a negative one).
Last time sebb responded to the announcement mail:
--------- 8>< ---------------
Please include a brief synopsis (1 or 2 sentences) of the purpose of
the TLP/Product in all announcements sent outside the TLP mailing
lists.
The developers and users will (presumably) know what the product is
about, but others are unlikely to know.
S.
P.S. Just about every other TLP includes this information, including HTTD...
--------- 8>< ---------------
You might want to add such type of info to the announcement for 1.1.27.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
