Author: kkolinko Date: Wed Aug 24 23:46:50 2011 New Revision: 1161322 URL: http://svn.apache.org/viewvc?rev=1161322&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51713 Improve message that is logged if there is a typo in the value of protocol in a <Connector> element.
Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/catalina/connector/Connector.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Connector.java?rev=1161322&r1=1161321&r2=1161322&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/Connector.java (original) +++ tomcat/trunk/java/org/apache/catalina/connector/Connector.java Wed Aug 24 23:46:50 2011 @@ -74,9 +74,8 @@ public class Connector extends Lifecycle Class<?> clazz = Class.forName(protocolHandlerClassName); this.protocolHandler = (ProtocolHandler) clazz.newInstance(); } catch (Exception e) { - log.error - (sm.getString - ("coyoteConnector.protocolHandlerInstantiationFailed", e)); + log.error(sm.getString( + "coyoteConnector.protocolHandlerInstantiationFailed", e), e); } } Modified: tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties?rev=1161322&r1=1161321&r2=1161322&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties (original) +++ tomcat/trunk/java/org/apache/catalina/connector/LocalStrings.properties Wed Aug 24 23:46:50 2011 @@ -21,7 +21,7 @@ coyoteConnector.cannotRegisterProtocol=C coyoteConnector.invalidPort=The connector cannot start since the specified port value of [{0}] is invalid coyoteConnector.protocolHandlerDestroyFailed=Protocol handler destroy failed coyoteConnector.protocolHandlerInitializationFailed=Protocol handler initialization failed -coyoteConnector.protocolHandlerInstantiationFailed=Protocol handler instantiation failed +coyoteConnector.protocolHandlerInstantiationFailed=Protocol handler instantiation failed: {0} coyoteConnector.protocolHandlerStartFailed=Protocol handler start failed coyoteConnector.protocolRegistrationFailed=Protocol JMX registration failed coyoteConnector.protocolHandlerPauseFailed=Protocol handler pause failed --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org