https://issues.apache.org/bugzilla/show_bug.cgi?id=51226
--- Comment #3 from Eiji Takahashi <mashm...@gmail.com> 2011-05-23 01:41:04 UTC --- Thanks for comments. (In reply to comment #2) > Thanks for the report and the patch. There were a couple of minor issues with > the patch and one slightly more serious issue. > > First the minor issues: > - no license header in FindLeaksTask.java added license header > - a couple of unused imports in FindLeaksTask.java removed two unused imports > > Tomcat includes a checkstyle configuration in /res/checkstyle that you can use > with your IDE. Alternatively, you can set execute.validate=true in your > build.properties and ant will run the checkstyle checks. I ran ant with execute.validate=true, and I got no error. > The bigger issue is that the patch changes the output format of find leaks for > the manager application. The output is intended to be a plain text list of > leaking contexts that can be parsed easily by the client. Adding the > additional > text from the HTML Manager to the Manager will make it much more difficult for > a client to parse the output. I added the new request parameter "status". If set this parameter to true, ManagerServlet returns the message that starts with "OK -". This parameter is used only by the Ant task. If set this parameter to false or not set, ManagerServlet and HTMLManagerServlet return the same message as before. > > If you submit an updated patch, it should get applied pretty quickly. If not, > one of the committers will probably make the necessary changes to this patch > and apply it but that is likely to take a little longer. I'll attach the new patch. Best regards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
