https://issues.apache.org/bugzilla/show_bug.cgi?id=51226
--- Comment #2 from Mark Thomas <ma...@apache.org> 2011-05-19 09:10:40 UTC --- Thanks for the report and the patch. There were a couple of minor issues with the patch and one slightly more serious issue. First the minor issues: - no license header in FindLeaksTask.java - a couple of unused imports in FindLeaksTask.java Tomcat includes a checkstyle configuration in /res/checkstyle that you can use with your IDE. Alternatively, you can set execute.validate=true in your build.properties and ant will run the checkstyle checks. The bigger issue is that the patch changes the output format of find leaks for the manager application. The output is intended to be a plain text list of leaking contexts that can be parsed easily by the client. Adding the additional text from the HTML Manager to the Manager will make it much more difficult for a client to parse the output. If you submit an updated patch, it should get applied pretty quickly. If not, one of the committers will probably make the necessary changes to this patch and apply it but that is likely to take a little longer. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
