On 09/03/2011 14:01, Rainer Jung wrote: > On 09.03.2011 14:46, Mark Thomas wrote: > Any idea about a good place from where to call? finishResponse is called > from CoyoteAdapter and CometEventImpl. At least we could call > request.finishRequest() form inside response.finishResponse().
Fixed in r1084949. I called request.finishRequest() anywhere there was a call to response.finishResponse(). >> I thought the default was do not swallow. The important thing is that >> this patch doesn't change the default. > > Terminology: AbstractInputBuffer has a flag called swallowInput, which > is true by default. True means: read additional data after the end of > the response (drain the connection). This default is not changed. > > Our new config item is called swallowAbortedUploads, again default is > "true", i.e. drain the connection until no more data. Unchanged from > before the patch. I was getting confused with the code in the Processor that always aborts reading the input if there is an error. I think it is worth adding a note on this to the docs. I'll do that shortly. >> From a performance point of view, I think do not swallow and close the >> connection is the right thing to do. > > OK, so that's something the admin or dev has to enable explicitely via > the config. Fair enough. I think the default should be changed but we can see what the user feedback is and change that later if desired. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
