On 09/03/2011 05:41, Rainer Jung wrote: > Hi all, > > some things I noticed while implementing the new switch: > > - o.a.c.connector.Request and Response hav methods finishRequest() resp. > finishResponse(). The mehod in the request seems not to be called. > Although that's not a big issue, because the omplementation is empty, > one would run into trouble when starting to add code to it (at least I > wondered why it wasn't working)
That looks like an oversight. > - Should we keep the swallow default in TC 7 (default is "do swallow", > i.e. read all of the remaining bytes, thereby keeping the thread busy > for a possibly long time but also keeping browsers happy which will > otherwise most likely not read the response). I'd say "keep swallowing" > but had the impression that Mark is more concerned about it and prefers > the "do not swallow" default. I thought the default was do not swallow. The important thing is that this patch doesn't change the default. >From a performance point of view, I think do not swallow and close the connection is the right thing to do. > - Domain and path of the session cookie are listed in config/context.xml > as configurable per context. The name is not listed, although the setter > is there and the value is respected in ApplicationSessionCookieConfig. > Is this an oversight? Should I add the name to the context parameter > list in the docs? Yep, that is an oversight. If you could add it that would be great. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
