On 03/06/2010 14:50, Rainer Jung wrote:
> +1000
:)

> Another related observation: Users often are not aware that they can
> substitute "common" with an individual log pattern, although that is
> very often essential (like including %D etc.). Even though many know
> similar constructs from Apache httpd, it's not obvious for them that
> they can substitute the word "common" with a pattern.
> 
> Should we add an example pattern to server.xml? Or would it be easier
> understandable if we removed the abbreviation "common" from the default
> config and replace it with the full pattern?
> 
> There's also the topic that the common pattern contains quotation marks,
> which you can't add verbatim to the attribute if you want to extend the
> common pattern with additional items. So adding an example or using the
> real pattern in the default configuration would show users how to work
> around that (" or similar).

I like explicitly defining the pattern along with a comment that this is
equivalent to common.

1 commit, coming up.

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to